[libav-devel] [PATCH 1/1] h264/x86: sign extend int stride in deblock functions

Janne Grunau janne-libav at jannau.net
Sun Jan 27 12:05:33 CET 2019


On 2019-01-27 11:39:13 +0100, Diego Biurrun wrote:
> On Sun, Jan 27, 2019 at 11:18:41AM +0100, Janne Grunau wrote:
> > Fixes checkasm errors after adding the h264 deblock tests.
> > ---
> >  libavcodec/x86/h264_deblock.asm       | 8 ++++++++
> >  libavcodec/x86/h264_deblock_10bit.asm | 9 +++++++++
> >  2 files changed, 17 insertions(+)
> 
> Shouldn't some int types be converted to ptrdiff_t instead?

that would be another possible solution but h264 seems to use int for 
stride consistently. So changing stride to ptrdiff_t is much more effort
and riskier since it touches more functions and architectures.

Janne


More information about the libav-devel mailing list