[libav-devel] [PATCH 01/19] libavcodec: vp8 neon optimizations for aarch64

Diego Biurrun diego at biurrun.de
Mon Feb 4 11:34:51 CET 2019


On Fri, Feb 01, 2019 at 11:12:40AM +0200, Martin Storsjö wrote:
> --- a/libavcodec/aarch64/Makefile
> +++ b/libavcodec/aarch64/Makefile
> @@ -44,6 +44,8 @@ NEON-OBJS-$(CONFIG_MPEGAUDIODSP)        += aarch64/mpegaudiodsp_neon.o
>  NEON-OBJS-$(CONFIG_DCA_DECODER)         += aarch64/dcadsp_neon.o               \
>                                             aarch64/synth_filter_neon.o
>  NEON-OBJS-$(CONFIG_VORBIS_DECODER)      += aarch64/vorbisdsp_neon.o
> +NEON-OBJS-$(CONFIG_VP8DSP)              += aarch64/vp8dsp_init_aarch64.o       \
> +                                           aarch64/vp8dsp_neon.o

This entry belongs with subsystems, not decoders.

> --- /dev/null
> +++ b/libavcodec/aarch64/vp8dsp_init_aarch64.c
> @@ -0,0 +1,81 @@
> +
> +av_cold void ff_vp78dsp_init_aarch64(VP8DSPContext *dsp)
> +{
> +    if (!have_neon(av_get_cpu_flags())) {
> +        return;
> +    }
> +}
> +
> +av_cold void ff_vp8dsp_init_aarch64(VP8DSPContext *dsp)
> +{
> +    if (!have_neon(av_get_cpu_flags())) {
> +        return;
> +    }
> +}

nit: pointless {}

> --- a/libavcodec/vp8dsp.c
> +++ b/libavcodec/vp8dsp.c
> @@ -685,6 +685,8 @@ av_cold void ff_vp78dsp_init(VP8DSPContext *dsp)
>          ff_vp78dsp_init_ppc(dsp);
>      if (ARCH_X86)
>          ff_vp78dsp_init_x86(dsp);
> +    if (ARCH_AARCH64)
> +        ff_vp78dsp_init_aarch64(dsp);
>  }
> @@ -743,5 +745,7 @@ av_cold void ff_vp8dsp_init(VP8DSPContext *dsp)
>          ff_vp8dsp_init_arm(dsp);
>      if (ARCH_X86)
>          ff_vp8dsp_init_x86(dsp);
> +    if (ARCH_AARCH64)
> +        ff_vp8dsp_init_aarch64(dsp);

order

I see that a later patch reorders this, I would suggest squashing.

All the non-assembly bits LGTM.

Diego


More information about the libav-devel mailing list