[libav-devel] [PATCH 1/2] configure: Try adding -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 for mingw as well

Martin Storsjö martin at martin.st
Fri Apr 12 23:58:40 CEST 2019


On Fri, 12 Apr 2019, Luca Barbato wrote:

> On 11/04/2019 15:35, Martin Storsjö wrote:
>> On Wed, 10 Apr 2019, Luca Barbato wrote:
>> 
>>> On 10/04/2019 10:48, Martin Storsjö wrote:
>>>> Mingw headers have got header inline implementations of localtime_r
>>>> and gmtime_r, but only visible if certain posix thread safe functions
>>>> have been requested.
>>>>
>>>> This is a preparatory step for improving the detection of those
>>>> functions.
>>>> ---
>>>> An alternative fix is also provided in a different patch series,
>>>> by adjusting libavutil/time_internal.h.
>>>> ---
>>>>   configure | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>
>>> Seems fine to me.
>> 
>> Which ones do you mean - this series of 2 patches, the other one, or both?
>> 
>
> This series seems fine to me.

Ok. FWIW, the change in mingw-w64 that broke it was reverted (there was a 
similar issue within gcc as well), but I guess this change probably is 
good to make anyway.

// Martin


More information about the libav-devel mailing list