[libav-devel] [PATCH 2/2] configure: Include time.h when checking for gmtime_r and localtime_r

Martin Storsjö martin at martin.st
Wed Apr 10 10:48:25 CEST 2019


These functions are available in time.h (conditional on posix thread
safe functions) on mingw.

Previously, these functions weren't detected by configure, and
libavutil/time_internal.h provided replacements, even if time.h
actually contained definitions of them.

Previously, these mingw inline functions were defined as
 "extern __inline __attribute__((__gnu_inline__))". In this case,
redefining a new static inline version of the same function with the
same name was accepted.

But recently, the mingw inline functions have changed to be declared
as "static inline", where it no longer is allowed to have
libavutil/time_internal.h redefine new static inline versions.
---
Contrary to what is mentioned in a similar commit
1b4dd59e5fbdebb8d9f13ad2dbdaa0179d0cce57 in ffmpeg, using
check_func_headers works just fine, provided that the posix defines
have been added. (Without them, check_builtin, which that commit
used, doesn't work either.)
---
 configure | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 3e8f2dcde1..8c46a870c4 100755
--- a/configure
+++ b/configure
@@ -4543,9 +4543,7 @@ check_func  gethrtime
 check_func  getopt
 check_func  getrusage
 check_func  gettimeofday
-check_func  gmtime_r
 check_func  isatty
-check_func  localtime_r
 check_func  mkstemp
 check_func  mmap
 check_func  mprotect
@@ -4561,6 +4559,8 @@ check_func  usleep
 check_func_headers io.h setmode
 check_func_headers mach/mach_time.h mach_absolute_time
 check_func_headers stdlib.h getenv
+check_func_headers time.h gmtime_r
+check_func_headers time.h localtime_r
 
 check_func_headers windows.h GetProcessAffinityMask
 check_func_headers windows.h GetProcessTimes
-- 
2.17.1



More information about the libav-devel mailing list