[libav-devel] [PATCH 16/20] tests: Move do_lavf() to fate-run.sh

Diego Biurrun diego at biurrun.de
Fri Sep 21 14:56:26 CEST 2018


On Thu, Sep 20, 2018 at 01:39:20PM +0200, Vittorio Giovara wrote:
> On Thu, Sep 20, 2018 at 10:47 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > --- a/tests/fate-run.sh
> > +++ b/tests/fate-run.sh
> > -FATE_LAVF-$(call ENCDEC2, MPEG4,      MP2,       NUT)                += nut
> >  FATE_LAVF-$(call ENCMUX,  RV10 AC3_FIXED,        RM)                 += rm
> > -FATE_LAVF-$(call ENCDEC,  FLV,                   SWF)                += swf
> > -FATE_LAVF-$(call ENCDEC2, MPEG2VIDEO, MP2,       MPEGTS)             += ts
> >  FATE_LAVF-$(CONFIG_YUV4MPEGPIPE_MUXER)                               += y4m
> >
> > +
> > +FATE_LAVF_LAVF-$(call ENCDEC2, MSMPEG4V3,  MP2,       ASF)
> > += asf
> 
> LAVF_LAVF? :-/
> isn't there a way to prevent this duplication?

Admittedly, this is not pretty. I'd have to rename the testing function as
well, the Make variables match the testing function names. Suggestions?

> > --- a/tests/ref/lavf/asf
> > +++ b/tests/ref/lavf/asf
> > @@ -1,3 +1,3 @@
> > -33e857a06b2b5dedce0bf76c9973944c *./tests/data/fate/lavf.asf
> > -333379 ./tests/data/fate/lavf.asf
> > -./tests/data/fate/lavf.asf CRC=0xf6340a10
> > +33e857a06b2b5dedce0bf76c9973944c *tests/data/fate/lavf.asf
> > +333379 tests/data/fate/lavf.asf
> > +tests/data/fate/lavf.asf CRC=0xf6340a10
> 
> is there a way to avoid having to modify these test files?

Not really; the "./" is a remnant of the legacy test infrastructure.
All the other reference files do not have it, so I think the change
is actually an improvement.

> or does changing the path (dropping "./") actually matter?

It matters because the files are compared literally, character by character.

Diego


More information about the libav-devel mailing list