[libav-devel] [PATCH 16/20] tests: Move do_lavf() to fate-run.sh

Vittorio Giovara vittorio.giovara at gmail.com
Thu Sep 20 13:39:20 CEST 2018


On Thu, Sep 20, 2018 at 10:47 AM, Diego Biurrun <diego at biurrun.de> wrote:

> ---
>  tests/fate-run.sh        |  7 ++++++
>  tests/fate/avformat.mak  | 53 +++++++++++++++++++++++++++++++------------
>  tests/lavf-regression.sh | 59 ------------------------------
> ------------------
>  tests/ref/lavf/asf       |  6 ++---
>  tests/ref/lavf/avi       |  6 ++---
>  tests/ref/lavf/dv        |  6 ++---
>  tests/ref/lavf/flv       |  6 ++---
>  tests/ref/lavf/gxf       |  6 ++---
>  tests/ref/lavf/mkv       |  6 ++---
>  tests/ref/lavf/mov       |  6 ++---
>  tests/ref/lavf/mpg       |  6 ++---
>  tests/ref/lavf/mxf       |  6 ++---
>  tests/ref/lavf/mxf_d10   |  6 ++---
>  tests/ref/lavf/nut       |  6 ++---
>  tests/ref/lavf/swf       |  6 ++---
>  tests/ref/lavf/ts        |  6 ++---
>  16 files changed, 84 insertions(+), 113 deletions(-)
>
> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
> index f8c3444e29..d6eb556dae 100755
> --- a/tests/fate-run.sh
> +++ b/tests/fate-run.sh
> -FATE_LAVF-$(call ENCDEC2, MPEG4,      MP2,       NUT)                +=
> nut
>  FATE_LAVF-$(call ENCMUX,  RV10 AC3_FIXED,        RM)                 += rm
> -FATE_LAVF-$(call ENCDEC,  FLV,                   SWF)                +=
> swf
> -FATE_LAVF-$(call ENCDEC2, MPEG2VIDEO, MP2,       MPEGTS)             += ts
>  FATE_LAVF-$(CONFIG_YUV4MPEGPIPE_MUXER)                               +=
> y4m
>
> +
> +FATE_LAVF_LAVF-$(call ENCDEC2, MSMPEG4V3,  MP2,       ASF)
> += asf
>

LAVF_LAVF? :-/
isn't there a way to prevent this duplication?

diff --git a/tests/ref/lavf/asf b/tests/ref/lavf/asf
> index 9a808d4e9a..ece5beb833 100644
> --- a/tests/ref/lavf/asf
> +++ b/tests/ref/lavf/asf
> @@ -1,3 +1,3 @@
> -33e857a06b2b5dedce0bf76c9973944c *./tests/data/fate/lavf.asf
> -333379 ./tests/data/fate/lavf.asf
> -./tests/data/fate/lavf.asf CRC=0xf6340a10
> +33e857a06b2b5dedce0bf76c9973944c *tests/data/fate/lavf.asf
> +333379 tests/data/fate/lavf.asf
> +tests/data/fate/lavf.asf CRC=0xf6340a10
>

is there a way to avoid having to modify these test files?
or does changing the path (dropping "./") actually matter?

-- 
Vittorio


More information about the libav-devel mailing list