[libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should release frame

Maxym Dmytrychenko maxim.d33 at gmail.com
Tue Sep 18 20:37:25 CEST 2018


On Tue, Sep 18, 2018 at 6:45 PM Li, Zhong <zhong.li at intel.com> wrote:

> > From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf Of
> Luca
> > Barbato
> > Sent: Wednesday, September 19, 2018 12:11 AM
> > To: libav-devel at libav.org
> > Subject: Re: [libav-devel] [PATCH] qsvenc: AV_PIX_FMT_QSV path should
> > release frame
> >
> > On 18/09/2018 09:54, Maxym Dmytrychenko wrote:
> > > Fixes high memory usage, now is back to normal.
> > >
> > > Can be checked as:
> > > -hwaccel qsv -c:v h264_qsv -i ../h264-conformance/CANL2_Sony_E.jsv
> > > -c:v h264_qsv -b:v 2000k -y qsv.mp4
> > > ---
> > >  libavcodec/qsvenc.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index
> > > 611449cbe..17a0559f3 100644
> > > --- a/libavcodec/qsvenc.c
> > > +++ b/libavcodec/qsvenc.c
> > > @@ -1028,6 +1028,9 @@ static void
> > clear_unused_frames(QSVEncContext *q)
> > >      QSVFrame *cur = q->work_frames;
> > >      while (cur) {
> > >          if (cur->used && !cur->surface.Data.Locked) {
> > > +            if (cur->frame->format == AV_PIX_FMT_QSV) {
> > > +                av_frame_unref(cur->frame);
> > > +            }
> > >              cur->used = 0;
> > >          }
> > >          cur = cur->next;
> > >
> >
> > Please put a note about why this is needed (and safe to do).
> >
> > lu
>
> I am still confused by the original commit (
> https://patchwork.libav.org/patch/64323/ ) which introduce the regression:
>          if (cur->used && !cur->surface.Data.Locked) {
> -            av_frame_unref(cur->frame);
>              cur->used = 0;
>          }
> It made sense for qsv decoding + qsv encoding pipeline(both GPU memory
> mode, thus format = AV_PIX_FMT_QSV, and system memory mode, thus format !=
> AV_PIX_FMT_QSV).
> Because if it is unlocked, qsv decoder doesn't need this surface any more,
> then we can release it.
> Removing "av_frame_unref(cur->frame)" is breaking qsv decoding + qsv
> encoding pipeline. The patch above just fix GPU memory mode case, but
> doesn’t work for system mode case of qsv decoding+ qsv encoding.
>
>
>
should be fixed by now for any case, or ?

regards
Max


More information about the libav-devel mailing list