[libav-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth support

Li, Zhong zhong.li at intel.com
Thu Oct 11 11:49:14 CEST 2018


> From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf Of Luca
> Barbato
> Sent: Thursday, October 11, 2018 5:34 PM
> To: libav-devel at libav.org
> Subject: Re: [libav-devel] [PATCH 1/2] lavc/qsvenc_jpeg: add async_depth
> support
> 
> On 11/10/2018 11:26, Zhong Li wrote:
> > Currently qsv (m)jpeg encoding is broken.
> > Regression introducing by the commit(id: c1bcd3): fix async support,
> > which requires the minimum async_depth to be 1, instead previous zero.
> > But the default async_depth of qsv (m)jpeg encoding is still
> > initialized
> > (mostly) as zero.
> >
> > This patch also abviously improves qsv (m)jpeg encoding performance
> > due to the default async_depth is changed to 4.
> >
> > Signed-off-by: Zhong Li <zhong.li at intel.com>
> > ---
> >  libavcodec/qsvenc_jpeg.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/libavcodec/qsvenc_jpeg.c b/libavcodec/qsvenc_jpeg.c index
> > e11b74d..7465bb9 100644
> > --- a/libavcodec/qsvenc_jpeg.c
> > +++ b/libavcodec/qsvenc_jpeg.c
> > @@ -64,6 +64,7 @@ static av_cold int qsv_enc_close(AVCodecContext
> > *avctx)  #define OFFSET(x) offsetof(QSVMJPEGEncContext, x)  #define
> VE
> > AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> static const
> > AVOption options[] = {
> > +    { "async_depth", "Maximum processing parallelism",
> > + OFFSET(qsv.async_depth), AV_OPT_TYPE_INT, { .i64 =
> > + ASYNC_DEPTH_DEFAULT }, 1, INT_MAX, VE },
> >      { NULL },
> >  };
> >
> >
> 
> both look fine. I'd merge them this evening.
> 
> lu

Thanks for quick reply, : ) 


More information about the libav-devel mailing list