[libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable MFE mode

Diego Biurrun diego at biurrun.de
Wed May 23 10:13:15 CEST 2018


On Wed, May 23, 2018 at 03:15:14AM +0000, Li, Zhong wrote:
> > From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf Of
> > Diego Biurrun
> > Sent: Tuesday, May 22, 2018 6:30 PM
> > To: libav development <libav-devel at libav.org>
> > Subject: Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to disable
> > MFE mode
> > 
> > On Tue, May 22, 2018 at 08:03:00AM +0000, Li, Zhong wrote:
> > > > -----Original Message-----
> > > > From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf
> > > > Of Diego Biurrun
> > > > Sent: Monday, May 21, 2018 11:17 PM
> > > > To: libav development <libav-devel at libav.org>
> > > > Subject: Re: [libav-devel] [PATCH V2] lavc/qsvenc: add an option to
> > > > disable MFE mode
> > > >
> > > > On Mon, May 21, 2018 at 02:33:28PM +0800, Zhong Li wrote:
> > > > >
> > > > > V2: remove the manual option since it is not supported now.
> > > >
> > > > This looks like a patch annotation that should not be part of the
> > > > log message.
> > >
> > > MFE manual mode hasn't been implemented in libav right now, so the
> > option shouldn't been exposed. I am not sure where the better place is to
> > give such an annotation.
> > > I am ok to send an updated patch to remove it if without any other
> > changes required. Or anyone can help to modify the log message when
> > merge this patch?
> > 
> > Use the --annotate option to git-send-email and add the annotation below
> > the "---".
> 
> Thanks for your explanation and I understand it now.
> But I prefer to keep it in log message because I want to explain why MSDK has MFX_MF_MANUAL but we don't expose it.
> And it also can remind developer if he want to add such an option, he need to change current MFE implantation.
> If the log message is not very clear, I can update it, but I don't think take it as an annotation is a good idea since it will be lost when patch applied. 
> How do you think?

As part of the log message it does not make any sense as currently written.
The patch does not remove the manual option. If you feel it is valuable to
add something like the text above into the log message, go right ahead.

Diego


More information about the libav-devel mailing list