[libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type

Li, Zhong zhong.li at intel.com
Thu Mar 29 15:33:17 CEST 2018


> From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf Of
> Diego Biurrun
> Sent: Thursday, March 29, 2018 12:55 AM
> To: libav development <libav-devel at libav.org>
> Subject: Re: [libav-devel] [PATCH] lavc/qsvdec: expose frame pic_type
> 
> On Wed, Mar 28, 2018 at 04:50:10PM +0800, Zhong Li wrote:
> > Currently pict_type are unset.
> > Add an extra param to fetch the picture type from qsv decoder
> >
> > v2: fix the compile error since AV_PICTURE_TYPE_NONE is not existed in
> libav.
> > v3: remove the key_frame setting because the judgement “key frame is
> > equal to IDR frame” only suitable for H264.
> 
> These look like sensible patch annotations that you can add with --annotate
> when using git-send-email, but they should not be part of the log message.
> How you fixed compilation failures needs not be preserved for posterity ;)

Agree, will remove it in the updated patch.

> 
> > --- a/libavcodec/qsv.c
> > +++ b/libavcodec/qsv.c
> > @@ -195,6 +195,30 @@ int ff_qsv_find_surface_idx(QSVFramesContext
> > *ctx, QSVFrame *frame)
> >
> > +enum AVPictureType ff_qsv_map_pictype(int mfx_pic_type) {
> > +    enum AVPictureType type;
> > +    switch (mfx_pic_type & 0x7) {
> > +        case MFX_FRAMETYPE_I:
> 
> Please indent switch and case at the same level.
> 
> Diego

Yup, will update it, thanks for pointing this. : )  



More information about the libav-devel mailing list