[libav-devel] [PATCH] configure: Restore original endianness test

Diego Biurrun diego at biurrun.de
Thu Mar 8 15:11:48 CET 2018


On Thu, Mar 08, 2018 at 01:44:38PM +0100, Luca Barbato wrote:
> On 08/03/2018 11:50, Diego Biurrun wrote:
> > Previously the bit pattern for the endianness test was declared as a
> > global, instead of a local, variable. This ensures that the pattern
> > appears unchanged in the object file and is not optimized out.
> > --- a/configure
> > +++ b/configure
> > @@ -4211,7 +4211,9 @@ done
> >   check_cc pragma_deprecated "" '_Pragma("GCC diagnostic ignored \"-Wdeprecated-declarations\"")'
> > -require_cc "endian test" "" "unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E'"
> > +test_cc <<EOF || die "endian test failed"
> > +unsigned int endian = 'B' << 24 | 'I' << 16 | 'G' << 8 | 'E';
> > +EOF
> >   od -t x1 $TMPO | grep -q '42 *49 *47 *45' && enable bigendian
> >   check_gas() {
> 
> You might add a comment to make sure nobody would think about simplifying it
> in the future.

Done.

Diego


More information about the libav-devel mailing list