[libav-devel] [PATCH] configure: fix inline asm checks

Luca Barbato lu_zero at gentoo.org
Thu Jun 7 16:05:17 CEST 2018


On 07/06/2018 14:03, Martin Storsjö wrote:
> From: John Cox <jc at kynesim.co.uk>
> 
> Commit 8c893aa3cd5 removed quotes that were required to detect
> inline asm:
> 
> check_insn armv5te qadd r0, r0, r0
> .../test.c:1:34: error: expected string literal in 'asm'
> void foo(void){ __asm__ volatile(qadd r0, r0, r0); }
> 
> The correct code is:
> 
> void foo(void){ __asm__ volatile("qadd r0, r0, r0"); }
> 
> Commit message written by Frank Liberato <liberato at chromium.org>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 5e79c0cec1..48e8536b07 100755
> --- a/configure
> +++ b/configure
> @@ -866,7 +866,7 @@ EOF
>  
>  check_insn(){
>      log check_insn "$@"
> -    check_inline_asm ${1}_inline "$2"
> +    check_inline_asm ${1}_inline "\"$2\""
>      check_as ${1}_external "$2"
>  }
>  
> 

Sure.


More information about the libav-devel mailing list