[libav-devel] [PATCH] random_seed: use bcrypt instead of the old wincrypt API

Diego Biurrun diego at biurrun.de
Tue Apr 17 10:08:52 CEST 2018


On Mon, Apr 16, 2018 at 05:50:04PM +0300, Martin Storsjö wrote:
> From: Steve Lhomme <robux4 at ycbcr.xyz>
> 
> Remove the wincrypt API calls since we don't support XP anymore and
> bcrypt is available since Vista, even on Windows Store builds.
> ---
> Now with avutil_extralibs sorted alphabetically, and James' extended
> configure check included.
> 
> --- a/configure
> +++ b/configure
> @@ -4579,9 +4579,10 @@ check_header windows.h
>  
> +check_lib bcrypt   "windows.h bcrypt.h"   BCryptGenRandom      -lbcrypt &&
> +    check_cpp_condition bcrypt bcrypt.h "defined BCRYPT_RNG_ALGORITHM"

This is a workaround for an old, already-obsolete version of mingw64.
Before this shows up in a release it will be even more obsolete.  IMO
such workarounds are not worth the trouble; let the breakage occur where
the actual bugs are and do the fixes at the root. I consider that the
saner longterm strategy. Your call; push whichever version you prefer.

Diego


More information about the libav-devel mailing list