[libav-devel] [PATCH] rtsp: only break on parse_rtsp_message on error

Luca Barbato lu_zero at gentoo.org
Wed Nov 29 20:23:23 CET 2017


On 29/11/2017 20:16, Tristan Matthews wrote:
> Fix suggested by Luca Barbato.
> 
> This was causing spurious EOFs when using -rtsp_transport udp, as
> reported in https://bugzilla.libav.org/show_bug.cgi?id=1103
> ---
>   libavformat/rtsp.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 17a25a310..8bf9d9e3c 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -1998,7 +1998,9 @@ static int udp_read_packet(AVFormatContext *s, RTSPStream **prtsp_st,
>               }
>   #if CONFIG_RTSP_DEMUXER
>               if (rt->rtsp_hd && p[0].revents & POLLIN) {
> -                return parse_rtsp_message(s);
> +                if ((ret = parse_rtsp_message(s)) < 0) {
> +                    return ret;
> +                }
>               }
>   #endif
>           } else if (n == 0 && ++timeout_cnt >= MAX_TIMEOUTS) {
> 

Sounds good to me obviously :)


More information about the libav-devel mailing list