[libav-devel] [PATCH] configure: use subarch instead of arch to create .def files on mingw

Martin Storsjö martin at martin.st
Thu Nov 16 08:07:14 CET 2017


On Wed, 15 Nov 2017, James Almer wrote:

> arch is "x86" regardless of target being x86_32 or x86_64, and if
> configuring with asm disabled it's "c" instead.
> Using subarch (Always either "x86_32" or "x86_64") and adapting
> makedef makes sure the symbols are always detected correctly on
> x86_32.
> ---
> compat/windows/makedef | 2 +-
> configure              | 3 ++-
> 2 files changed, 3 insertions(+), 2 deletions(-)

Probably ok, although I think I've got an even better idea:

What about ditching the prefix guessing from makedef altogether? We 
already know it (in extern_prefix) within configure, so we could just pass 
that along to makedef instead of passing ARCH and guessing from that, or 
by running dumpbin -headers and trying to find the arch from there.

// Martin


More information about the libav-devel mailing list