[libav-devel] [PATCH] matroskadec: don't warn about unknown spherical medata when none is present

Sean McGovern gseanmcg at gmail.com
Thu Nov 2 21:12:47 CET 2017


Hi James,

On Nov 2, 2017 10:03, "James Almer" <jamrial at gmail.com> wrote:

track->video.projection.type is 0 by default, and is the value set by the
demuxer for files without the element.

Signed-off-by: James Almer <jamrial at gmail.com>
---
 libavformat/matroskadec.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index c6e1a190a8..5ed03bb642 100644
--- a/libavformat/matroskadec.c
+++ b/libavformat/matroskadec.c
@@ -1659,9 +1659,6 @@ static int mkv_parse_video_projection(AVStream *st,
const MatroskaTrack *track)
         }
         break;
     default:
-        av_log(NULL, AV_LOG_WARNING,
-               "Unknown spherical metadata type %"PRIu64"\n",
-               track->video.projection.type);
         return 0;
     }

--
2.14.2

_______________________________________________
libav-devel mailing list
libav-devel at libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Errrrr... I'm not sure this is a better than what I had (with which I agree
on your review point). Isn't this log message potentially useful for
corrupted streams?

Also please note that the sample from BZ #1055 currently registers as
projection type 15 which maps to the _NB. Pretty strange for a sample
hailing from 2008. I have a feeling the real bug is elsewhere...

-- Sean McGovern


More information about the libav-devel mailing list