[libav-devel] [PATCH 3/3] matroskadec: allow flavor 0 files to contain RealAudio streams

Martin Storsjö martin at martin.st
Thu Nov 2 07:50:50 CET 2017


On Wed, 1 Nov 2017, Sean McGovern wrote:

> Regression since 569d18aa9dc989c37bb4d4b968026fe5afa6fff9.
>
> Bug-Id: 1055
> Cc: libav-stable at libav.org
> ---
> libavformat/matroskadec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
> index 9c523fb..bad750c 100644
> --- a/libavformat/matroskadec.c
> +++ b/libavformat/matroskadec.c
> @@ -1919,7 +1919,7 @@ static int matroska_parse_tracks(AVFormatContext *s)
>             track->audio.sub_packet_h    = avio_rb16(&b);
>             track->audio.frame_size      = avio_rb16(&b);
>             track->audio.sub_packet_size = avio_rb16(&b);
> -            if (flavor                       <= 0 ||
> +            if (flavor                       < 0 ||
>                 track->audio.coded_framesize <= 0 ||
>                 track->audio.sub_packet_h    <= 0 ||
>                 track->audio.frame_size      <= 0 ||
> -- 
> 2.7.4

Possibly ok (the commit message of the offending commit doesn't indicate 
which sample it was about so I can't easily check whether that sample 
needed to check for strictly flavor <= 0 or not).

// Martin


More information about the libav-devel mailing list