[libav-devel] [PATCH] x264: Support version 155

Nicolas George george at nsup.org
Tue Dec 26 14:10:07 CET 2017


James Almer (2017-12-26):
> > +#if X264_BUILD >= 155
> > +    if (x4->params.i_bitdepth > 8)
> > +#else

> Wouldn't using av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth here
> as well be cleaner?

avctx->pix_fmt tells us what libavcodec wants; x4->params.i_bitdepth
tells us what x264 proposes; they are not necessarily the same thing.

You may want to check the similar change you made on FFmpeg.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://lists.libav.org/pipermail/libav-devel/attachments/20171226/2b0fbbf6/attachment.sig>


More information about the libav-devel mailing list