[libav-devel] [PATCH] qsv/vp8dec: fix memory leak issue

Li, Zhong zhong.li at intel.com
Thu Dec 7 14:49:27 CET 2017


> -----Original Message-----
> From: libav-devel [mailto:libav-devel-bounces at libav.org] On Behalf Of Luca
> Barbato
> Sent: Thursday, December 7, 2017 8:25 PM
> To: libav-devel at libav.org
> Subject: Re: [libav-devel] [PATCH] qsv/vp8dec: fix memory leak issue
> 
> On 07/12/2017 08:26, Zhong Li wrote:
> > Signed-off-by: Zhong Li <zhong.li at intel.com>
> > ---
> >   libavcodec/qsvdec_other.c | 5 +++++
> >   1 file changed, 5 insertions(+)
> >
> > diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c
> > index 1ba803b..cc5f205 100644
> > --- a/libavcodec/qsvdec_other.c
> > +++ b/libavcodec/qsvdec_other.c
> > @@ -60,6 +60,11 @@ static av_cold int
> qsv_decode_close(AVCodecContext *avctx)
> >   {
> >       QSVOtherContext *s = avctx->priv_data;
> >
> > +#if CONFIG_VP8_QSV_DECODER
> > +    if (avctx->codec_id == AV_CODEC_ID_VP8)
> > +        av_freep(&s->qsv.load_plugins); #endif
> > +
> >       ff_qsv_decode_close(&s->qsv);
> >
> >       qsv_clear_buffers(s);
> >
> 
> Are you sure? qsv.load_plugins should be an avoption and thus get
> automatically freed once you close the codec...

qsv.load_plugins is an avoption of qsv hevc decoder/encoder, but there is no option for vp8 decoder. 
Thus should be why I found memory leak for vp8, but no found for hevc using valgrind to analyze.



More information about the libav-devel mailing list