[libav-devel] [PATCH 1/6] webp: Treat data_size greater than INT_MAX as invalid

Anton Khirnov anton at khirnov.net
Fri Dec 18 14:42:24 CET 2015


Quoting Diego Biurrun (2015-12-17 13:28:06)
> ---
>  libavcodec/webp.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/libavcodec/webp.c b/libavcodec/webp.c
> index c475744..7826cab 100644
> --- a/libavcodec/webp.c
> +++ b/libavcodec/webp.c
> @@ -1309,10 +1309,8 @@ static int vp8_lossy_decode_frame(AVCodecContext *avctx, AVFrame *p,
>      }
>      s->lossless = 0;
>  
> -    if (data_size > INT_MAX) {
> -        av_log(avctx, AV_LOG_ERROR, "unsupported chunk size\n");
> -        return AVERROR_PATCHWELCOME;
> -    }
> +    if (data_size > INT_MAX)
> +        return AVERROR_INVALIDDATA;
>  

Does this actually fix anything? One can successfully argue for either
of those being "correct" (for some value of correct). And dropping error
messages is not nice, since they allow you to quickly identify the line
where it fails.

-- 
Anton Khirnov


More information about the libav-devel mailing list