[libav-devel] [PATCH] opus_silk: fix out of array read in silk_lsf2lpc

Andreas Cadhalpun andreas.cadhalpun at googlemail.com
Tue Dec 15 22:41:15 CET 2015

On 15.12.2015 08:17, Anton Khirnov wrote:
> Can you share the sample that shows the problem?

I could, but it's of no use for comparing with libopus, because their
decoder errors out in an unrelated check.

> From what I can see, libopus does not do any clipping at that point, so
> something else must ensure that there is no overflow.

Indeed, the real problem is just a silly typo...
It might have been caused by the fact that the specification uses
i and k in exactly the opposite way than the code.

New patch attached.

Best regards,

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-opus_silk-fix-typo-causing-overflow-in-silk_stabiliz.patch
Type: text/x-diff
Size: 1159 bytes
Desc: not available
URL: <http://lists.libav.org/pipermail/libav-devel/attachments/20151215/0e012622/attachment.patch>

More information about the libav-devel mailing list