[libav-devel] [PATCH] hls: Don't persist http options that haven't been set

Luca Barbato lu_zero at gentoo.org
Mon Dec 7 16:30:40 CET 2015


On 07/12/15 13:35, Martin Storsjö wrote:
> av_opt_get does return the empty string for options that aren't set.
> 
> This avoids warnings about "No trailing CRLF found in HTTP header."
> ---
>  libavformat/hls.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/hls.c b/libavformat/hls.c
> index dc3ab87..db4da31 100644
> --- a/libavformat/hls.c
> +++ b/libavformat/hls.c
> @@ -497,7 +497,7 @@ static int save_avio_options(AVFormatContext *s)
>      int ret = 0;
>  
>      while (*opt) {
> -        if (av_opt_get(s->pb, *opt, AV_OPT_SEARCH_CHILDREN, &buf) >= 0) {
> +        if (av_opt_get(s->pb, *opt, AV_OPT_SEARCH_CHILDREN, &buf) >= 0 && *buf) {
>              ret = av_dict_set(&c->avio_opts, *opt, buf,
>                                AV_DICT_DONT_STRDUP_VAL);
>              if (ret < 0)
> 

Ok.


More information about the libav-devel mailing list