[libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

Ganesh Ajjanagadde gajjanag at mit.edu
Mon Dec 7 00:44:37 CET 2015


On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
> On 06/12/15 20:30, Martin Storsjö wrote:
>> From: Ganesh Ajjanagadde <gajjanagadde at gmail.com>
>>
>> ---
>>  libavformat/rtsp.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
>> index 2c616e8..4beb275 100644
>> --- a/libavformat/rtsp.c
>> +++ b/libavformat/rtsp.c
>> @@ -2279,6 +2279,7 @@ static int sdp_read_header(AVFormatContext *s)
>>              if (err) {
>>                  av_log(s, AV_LOG_ERROR, "getnameinfo: %s\n", gai_strerror(err));
>>                  err = AVERROR(EIO);
>> +                av_dict_free(&opts);
>>                  goto fail;
>>              }
>>              ff_url_join(url, sizeof(url), "rtp", NULL,
>>
>
> Sounds good.

As the author of the patch, I don't really mind how this is taken care
of. Also, I don't know if patches reveal this information completely.

But it seems to me that "From: " is not an appropriate tag; the
"Signed-off-by" has been stripped away. Maybe even the --author= field
is incorrect, I don't know.
Vittorio seemed to handle it correctly:
https://lists.libav.org/pipermail/libav-devel/2015-September/072108.html.

I personally do not care about correct attribution for my work. The
only reason I bring this up is because it can affect commit
statistics, a classic argument of Libav vs FFmpeg, and I don't want to
distort it.

> _______________________________________________
> libav-devel mailing list
> libav-devel at libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel


More information about the libav-devel mailing list