[libav-devel] [PATCH] Add libkvazaar HECV encoder
lu_zero at gentoo.org
Mon Aug 24 15:25:14 CEST 2015
On 24/08/15 14:26, Arttu Ylä-Outinen wrote:
>>>> + av_assert0(frame->width == ctx->config->width);
>>>> + av_assert0(frame->height == ctx->config->height);
>>>> + av_assert0(frame->format == avctx->pix_fmt);
>>> This may happen normally, do not crash this way, return a clear message
>>> stating that it is not currently supported.
> I'll fix that. When would the dimensions of the input video actually
> change in the middle? I tried using images of different sizes as input
> to avconv but it didn't trigger those asserts.
avconv rescales on the fly, a normal user would not. Probably something
more structured (e.g. a capability) could be done about it but is
unrelated to this patch.
> It looks like av_copy_image could be used for copying the pixels. Should
> I change this to use that function or is it better to wait until Kvazaar
> has the required changes for avoiding the copy entirely?
Depends on when you want this integration to land =) If the change
happens soon enough I'd use it, kvazaar development speed is quite fast
so I'm not really concerned about users using an older version right now.
Thanks a lot =)
More information about the libav-devel