[libav-devel] [PATCH 3/5] samplefmt: Drop a spurious const from av_samples_fill_arrays

Anton Khirnov anton at khirnov.net
Tue Aug 11 10:14:20 CEST 2015


Quoting Luca Barbato (2015-08-03 22:51:50)
> The resulting mapped array is used as non-const.
> ---
>  libavutil/samplefmt.c | 2 +-
>  libavutil/samplefmt.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/libavutil/samplefmt.c b/libavutil/samplefmt.c
> index bff6004..453ba4c 100644
> --- a/libavutil/samplefmt.c
> +++ b/libavutil/samplefmt.c
> @@ -138,7 +138,7 @@ int av_samples_get_buffer_size(int *linesize, int nb_channels, int nb_samples,
>  }
>  
>  int av_samples_fill_arrays(uint8_t **audio_data, int *linesize,
> -                           const uint8_t *buf, int nb_channels, int nb_samples,
> +                           uint8_t *buf, int nb_channels, int nb_samples,
>                             enum AVSampleFormat sample_fmt, int align)
>  {
>      int ch, planar, buf_size, line_size;
> diff --git a/libavutil/samplefmt.h b/libavutil/samplefmt.h
> index 8347fac..766b8e6 100644
> --- a/libavutil/samplefmt.h
> +++ b/libavutil/samplefmt.h
> @@ -187,7 +187,7 @@ int av_samples_get_buffer_size(int *linesize, int nb_channels, int nb_samples,
>   * @return                 0 on success or a negative error code on failure
>   */
>  int av_samples_fill_arrays(uint8_t **audio_data, int *linesize,
> -                           const uint8_t *buf,
> +                           uint8_t *buf,
>                             int nb_channels, int nb_samples,
>                             enum AVSampleFormat sample_fmt, int align);
>  
> -- 
> 1.9.0
> 

Doesn't look right. buf is not modified in this function.

-- 
Anton Khirnov


More information about the libav-devel mailing list