[libav-devel] [PATCH] rtpdec_hevc: drop duplicated entry

Vittorio Giovara vittorio.giovara at gmail.com
Wed Sep 17 15:03:47 CEST 2014


On Wed, Sep 17, 2014 at 1:54 PM, Thomas Volkert <silvo at gmx.net> wrote:
> Hallo,
>
> Am 17.09.2014 14:27, schrieb Vittorio Giovara:
>>  RTPDynamicProtocolHandler ff_hevc_dynamic_handler = {
>> -    .enc_name         = "HEVC",
>> -    .codec_type       = AVMEDIA_TYPE_VIDEO,
>> -    .codec_id         = AV_CODEC_ID_HEVC,
>> -    .init             = hevc_init,
>> -    .parse_sdp_a_line = hevc_parse_sdp_line,
>> -    .alloc            = hevc_new_context,
>> -    .free             = hevc_free_context,
>> -    .parse_packet     = hevc_handle_packet
>> -};
>> -
>> -RTPDynamicProtocolHandler ff_h265_dynamic_handler = {
>>      .enc_name         = "H265",
>>      .codec_type       = AVMEDIA_TYPE_VIDEO,
>>      .codec_id         = AV_CODEC_ID_HEVC,
>
> Okay, it seems that this entry is a duplicated one. But the idea was to
> remain compatible to a possible "HEVC" description.
> So, if some other software signals "HEVC" inside SDP as indicator for
> H.265, the "duplicated entry" is needed.
> I would suggest to leave this duplicated entry in the code.

Hm, okay, would you mind just adding a comment in the code so that we
do not forget in the future?
Thanks.
-- 
Vittorio


More information about the libav-devel mailing list