[libav-devel] [PATCH 5/5] wmv2: cosmetics: Fix coding styles inconsistencies

Gabriel Dume gabriel.ddx84 at gmail.com
Tue Sep 2 19:39:42 CEST 2014


On Tue, Sep 2, 2014 at 6:32 AM, Diego Biurrun <diego at biurrun.de> wrote:

> On Mon, Sep 01, 2014 at 03:19:01PM -0400, Gabriel Dume wrote:
> > --- a/libavcodec/wmv2.c
> > +++ b/libavcodec/wmv2.c
> > @@ -51,84 +52,87 @@ av_cold void ff_wmv2_common_init(Wmv2Context * w){
> > -    case 1:
> > -        ff_simple_idct84_add(dst           , stride, block1);
> > -        ff_simple_idct84_add(dst + 4*stride, stride, w->abt_block2[n]);
> > -    case 2:
> > -        ff_simple_idct48_add(dst           , stride, block1);
> > -        ff_simple_idct48_add(dst + 4       , stride, w->abt_block2[n]);
> > +      case 1:
> > +          ff_simple_idct84_add(dst             , stride, block1);
> > +          ff_simple_idct84_add(dst + 4 * stride, stride,
> w->abt_block2[n]);
> > +      case 2:
> > +          ff_simple_idct48_add(dst           , stride, block1);
> > +          ff_simple_idct48_add(dst + 4       , stride,
> w->abt_block2[n]);
>
> Get rid of the stray spaces before comma.
>
> > -    wmv2_add_block(w, block1[0], dest_y                    ,
> s->linesize, 0);
> > -    wmv2_add_block(w, block1[1], dest_y + 8                ,
> s->linesize, 1);
> > +    wmv2_add_block(w, block1[0], dest_y                      ,
> s->linesize, 0);
> > +    wmv2_add_block(w, block1[1], dest_y + 8                  ,
> s->linesize, 1);
>
> same
>
> > -    wmv2_add_block(w, block1[4], dest_cb                   ,
> s->uvlinesize, 4);
> > -    wmv2_add_block(w, block1[5], dest_cr                   ,
> s->uvlinesize, 5);
> > +    wmv2_add_block(w, block1[4], dest_cb                     ,
> s->uvlinesize, 4);
> > +    wmv2_add_block(w, block1[5], dest_cr                     ,
> s->uvlinesize, 5);
>
> ditto


    w->wdsp.put_mspel_pixels_tab[dxy](dest_y,                    ptr,
                  linesize);
    w->wdsp.put_mspel_pixels_tab[dxy](dest_y     + 8,            ptr
  + 8,            linesize);
    w->wdsp.put_mspel_pixels_tab[dxy](dest_y     + 8 * linesize, ptr
  + 8 * linesize, linesize);
    w->wdsp.put_mspel_pixels_tab[dxy](dest_y + 8 + 8 * linesize, ptr +
8 + 8 * linesize, linesize);

how about this part? should i get rid of the spaces here too?


More information about the libav-devel mailing list