[libav-devel] [PATCH] arm: dsputil: Add missing config.h #include for restrict keyword

Martin Storsjö martin at martin.st
Fri Mar 14 12:51:33 CET 2014


On Fri, 14 Mar 2014, Diego Biurrun wrote:

> On Fri, Mar 14, 2014 at 12:26:05PM +0200, Martin Storsjö wrote:
>> On Fri, 14 Mar 2014, Diego Biurrun wrote:
>>> --- a/libavcodec/arm/dsputil_init_armv6.c
>>> +++ b/libavcodec/arm/dsputil_init_armv6.c
>>> @@ -20,6 +20,7 @@
>>>
>>> +#include "config.h"
>>> #include "libavutil/attributes.h"
>>> #include "libavcodec/avcodec.h"
>>> #include "libavcodec/dsputil.h"
>>
>> We could just as well drop the restrict keyword - before
>> compiliation was broken this used to produce a warning:
>>
>> libavcodec/arm/dsputil_init_armv6.c(69) : warning C4028: formal
>> parameter 2 different from declaration
>>
>> (It's harmless though - the function takes a restrict parameter, but
>> the function is set to a function pointer that doesn't have the
>> restrict keyword for that parameter.)
>
> You mean drop the restrict parameter globally or just from this ARM
> optimization bit?

I meant locally from this particular function. Since the restrict keyword 
is only present on the arm function, but the only place the function is 
used is via a function pointer which lacks the same restrict keyword, 
there's no gain from having it, and it gives these warnings about 
mismatching function signatures with MSVC as well.

// Martin


More information about the libav-devel mailing list