[libav-devel] [PATCH 022/132] dsputil.h: Clean up comments

Luca Barbato lu_zero at gentoo.org
Tue Mar 11 17:44:15 CET 2014


On 11/03/14 17:27, Diego Biurrun wrote:
> ---
>  libavcodec/dsputil.h | 85 ++++++++++++++++++++++++++++------------------------
>  1 file changed, 46 insertions(+), 39 deletions(-)
> 
> diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h
> index 81efd42..56bf569 100644
> --- a/libavcodec/dsputil.h
> +++ b/libavcodec/dsputil.h
> @@ -23,8 +23,8 @@
>  /**
>   * @file
>   * DSP utils.
> - * note, many functions in here may use MMX which trashes the FPU state, it is
> - * absolutely necessary to call emms_c() between dsp & float/double code
> + * Note, many functions in here may use MMX which trashes the FPU state, it is
@note ?
> + * absolutely necessary to call emms_c() between DSP & float/double code.
>   */
>  
>  #ifndef AVCODEC_DSPUTIL_H
> @@ -61,21 +61,22 @@ void ff_gmc_c(uint8_t *dst, uint8_t *src, int stride, int h, int ox, int oy,
>                int dxx, int dxy, int dyx, int dyy, int shift, int r, int width, int height);
>  
>  /* minimum alignment rules ;)
> -If you notice errors in the align stuff, need more alignment for some ASM code
> -for some CPU or need to use a function with less aligned data then send a mail
> -to the libav-devel mailing list, ...
> -
> -!warning These alignments might not match reality, (missing attribute((align))
> -stuff somewhere possible).
> -I (Michael) did not check them, these are just the alignments which I think
> -could be reached easily ...
> -
> -!future video codecs might need functions with less strict alignment
> -*/
> + * If you notice errors in the align stuff, need more alignment for some ASM code
> + * for some CPU or need to use a function with less aligned data then send a mail
> + * to the libav-devel mailing list, ...
> + *
> + * !warning These alignments might not match reality, (missing attribute((align))
@warning ?
> + * stuff somewhere possible).
> + * I (Michael) did not check them, these are just the alignments which I think
> + * could be reached easily ...

Is it still valid?

Same questions for the rest where there is a tag available in doxy.

lu


More information about the libav-devel mailing list