[libav-devel] [PATCH 2/2] configure: Group and sort function/struct/type checks

Diego Biurrun diego at biurrun.de
Tue Mar 11 00:08:20 CET 2014


On Mon, Mar 10, 2014 at 04:20:52PM +0100, Janne Grunau wrote:
> On 2014-03-06 14:55:06 +0100, Diego Biurrun wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -3805,19 +3805,19 @@ elif check_func dlopen -ldl; then
> >  
> >  if ! disabled network; then
> > -    check_type "sys/types.h sys/socket.h" socklen_t
> > +    check_func getaddrinfo $network_extralibs
> > +    check_func getservbyport $network_extralibs
> > +    check_func inet_aton $network_extralibs
> > +    check_struct "sys/types.h sys/socket.h" "struct sockaddr" sa_len
> 
> having this below 'check_type "sys/types.h sys/socket.h" socklen_t'
> would improve sorting

I tried to group the func, struct, and type checks into separate blocks.

> >      check_type netdb.h "struct addrinfo"
> >      check_type netinet/in.h "struct group_source_req" -D_BSD_SOURCE
> >      check_type netinet/in.h "struct ip_mreq_source" -D_BSD_SOURCE
> >      check_type netinet/in.h "struct ipv6_mreq" -D_DARWIN_C_SOURCE
> > -    check_type netinet/in.h "struct sockaddr_in6"
> >      check_type poll.h "struct pollfd"
> 
> this looks misordered

?

Diego


More information about the libav-devel mailing list