[libav-devel] [PATCH 1/2] g2meet: K&R formatting cosmetics

Tim Walker tdskywalker at gmail.com
Fri Mar 7 16:06:18 CET 2014


On 07 Mar 2014, at 15:36, Diego Biurrun <diego at biurrun.de> wrote:

> On Fri, Mar 07, 2014 at 03:34:33PM +0100, Kostya Shishkov wrote:
>> On Fri, Mar 07, 2014 at 03:31:12PM +0100, Diego Biurrun wrote:
>>> --- a/libavcodec/g2meet.c
>>> +++ b/libavcodec/g2meet.c
>>> @@ -320,10 +320,14 @@ static void kempf_restore_buf(const uint8_t *src, int len,
>>> 
>>> -    if (npal <= 2)       nb = 1;
>>> -    else if (npal <= 4)  nb = 2;
>>> -    else if (npal <= 16) nb = 4;
>>> -    else                 nb = 8;
>>> +    if (npal <= 2)
>>> +        nb = 1;
>>> +    else if (npal <= 4)
>>> +        nb = 2;
>>> +    else if (npal <= 16)
>>> +        nb = 4;
>>> +    else
>>> +        nb = 8;
>> 
>> I'd rather leave it as it - it was kinda tabular form that makes it easier to
>> undertand IMO.
> 
> I consider it just idiosyncratic formatting.  If you prefer I'll leave
> it as-is.  Patch OK with or without this hunk?

Without. For short lines like this, I like this kind of formatting too. Otherwise, make it a switch :-)

Tim


More information about the libav-devel mailing list