[libav-devel] [PATCH] configure: enable PIC on s390(x)

Diego Biurrun diego at biurrun.de
Tue Mar 4 14:48:51 CET 2014


On Sun, Mar 02, 2014 at 09:02:13AM -0500, Reinhard Tartler wrote:
> On Sun, Mar 2, 2014 at 3:13 AM, Diego Biurrun <diego at biurrun.de> wrote:
> > On Sun, Mar 02, 2014 at 02:14:54AM -0500, Reinhard Tartler wrote:
> >> --- a/configure
> >> +++ b/configure
> >> @@ -3222,6 +3222,10 @@ case "$arch" in
> >> +    s390)
> >> +        check_64bit s390 s390x 'sizeof(void *) > 4'
> >> +        spic=$shared
> >> +    ;;
> >
> > Are there 32/64 bit variants of S390?  Is the check just a stray change?
> 
> At least in Debian, there are two architectures, s390 and s390x. I've
> found the following mailing list post that shows their difference:
> https://lists.debian.org/debian-s390/2011/05/msg00009.html

OK, so system z / S390x is a 64-bit platform.

> Maybe you're right and we should just do this:
> 
> --- a/configure
> +++ b/configure
> @@ -3207,7 +3207,7 @@ check_64bit(){
>  }
> 
>  case "$arch" in
> -    aarch64|alpha|ia64)
> +    aarch64|alpha|ia64|s390)
>          spic=$shared
>      ;;
>      mips)
> 
> 
> I'm not sure if it was considered "safe" to not enable pic on 31bit
> s390 anyways (when compiling shared libs, that is).

I think it cannot hurt to set the subarch, so the original patch is OK.

Diego


More information about the libav-devel mailing list