[libav-devel] [PATCH] indeo2: rename stride to pitch for consistency with other Indeo decoders

Kostya Shishkov kostya.shishkov at gmail.com
Thu Jun 26 09:18:49 CEST 2014


On Thu, Jun 26, 2014 at 12:15:36AM +0200, Diego Biurrun wrote:
> On Wed, Jun 25, 2014 at 08:29:29PM +0200, Kostya Shishkov wrote:
> > ---
> >  libavcodec/indeo2.c |   16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> I strongly vote for my patch instead to have things more, not less,
> consistent across the codebase.  You trolled me into whipping it up,
> now accept it ;-p

No, your patch is to have things less, not more.
I prefer to have some variety inside codebase, otherwise it will end like
Soviet army where they painted grass green in order to conform with
regulations.

Of course having complete chaos is not good but not being able to name
variables in the way you prefer would be too sad.

P.S. Your patch sucks because it should rename both stride and pitch to
linesize for real consistency.


More information about the libav-devel mailing list