[libav-devel] [PATCH v3 1/2] configure: add support for neon intrinsics

Janne Grunau janne-libav at jannau.net
Thu Jun 19 21:21:29 CEST 2014


On 2014-06-19 18:55:45 +0200, Diego Biurrun wrote:
> On Thu, Jun 19, 2014 at 12:29:03PM +0200, Janne Grunau wrote:
> > --- a/configure
> > +++ b/configure
> > @@ -4403,6 +4411,17 @@ enabled_all dxva2 CoTaskMemFree &&
> >  
> > +for intrin in $INTRINSICS_LIST; do
> > +    if enabled $intrin; then
> > +        test -n "$intrinsics" &&
> > +            die "ERROR: Only one intrinsics instruction set can be enabled." ||
> > +            intrinsics="${intrin#intrinsics_}"
> > +    fi
> > +done
> 
> Can this ever happen?  And would it be a problem?

currently impossible with 1 value in INTRINSICS_LIST. Intended to ease 
support for adding other intrinsics. Considering the likelyhood of 
adding other intrinsics it's probably overengineered. Having more than 
one intrinsics enabled should be an error since we can only one.

> > +# prevent empty $intrinsics
> > +! enabled_any $INTRINSICS_LIST && intrinsics=no_intrinsics
> 
> I think it would be more elegant to set a default value like "none" or
> so instead.

using a default value makes the test above less elegant but all 
considered default value is better

Janne


More information about the libav-devel mailing list