[libav-devel] [PATCH] hevc: Allow out of bound values for num_reorder_pics

Anton Khirnov anton at khirnov.net
Mon Jun 16 07:47:47 CEST 2014


On Mon, 16 Jun 2014 01:56:58 +0200, Luca Barbato <lu_zero at gentoo.org> wrote:
> On 15/06/14 23:44, Guillaume Martres wrote:
> > From: Kieran Kunhya <kierank at obe.tv>
> > 
> > This fixes decoding for a sample that cannot be shared
> > ---
> > 
> > This version makes sure that num_reorder_pics <= MAX_DPB_SIZE - 1 and update
> > max_dec_pic_buffering to be consistent with num_reorder_pics
> > 
> >  libavcodec/hevc_ps.c | 15 ++++++++++-----
> >  1 file changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c
> > index 5e5d4a7..8aab590 100644
> > --- a/libavcodec/hevc_ps.c
> > +++ b/libavcodec/hevc_ps.c
> > @@ -375,9 +375,10 @@ int ff_hevc_decode_nal_vps(HEVCContext *s)
> >              goto err;
> >          }
> >          if (vps->vps_num_reorder_pics[i] > vps->vps_max_dec_pic_buffering[i] - 1) {
> > -            av_log(s->avctx, AV_LOG_ERROR, "vps_max_num_reorder_pics out of range: %d\n",
> > +            av_log(s->avctx, AV_LOG_WARNING, "vps_max_num_reorder_pics out of range: %d\n",
> >                     vps->vps_num_reorder_pics[i]);
> > -            goto err;
> 
> Maybe even this should be bound-checked?
> 

We do not use anything from VPS, so no point in that.

The patch looks fine to me as is.

-- 
Anton Khirnov


More information about the libav-devel mailing list