[libav-devel] [PATCH 089/132] dsputil: Initialize static dsputil data from within dsputil itself

Diego Biurrun diego at biurrun.de
Tue Jun 3 20:07:30 CEST 2014


On Wed, Mar 26, 2014 at 06:28:10PM +0100, Luca Barbato wrote:
> On 26/03/14 12:41, Diego Biurrun wrote:
> > ---
> >  libavcodec/dsputil.c | 10 ++++++++--
> >  libavcodec/dsputil.h |  1 -
> >  libavcodec/utils.c   | 13 -------------
> >  3 files changed, 8 insertions(+), 16 deletions(-)
> 
> The code seems more wrong than it was before.
> 
> Would be better to keep a function and call it from the init_static_data
> callback of the codecs that use it.

It's used by quite a few codecs and subsystems and also by codecs that
already declare such a callback, so I'm not sure how feasible this would
be.  Besides, we have many other codecs and subsystems that function in
this way, so would this patch really make things considerably worse?

Diego


More information about the libav-devel mailing list