[libav-devel] [PATCH] doc: Try to find Perl in nonstandard path from the environment

Martin Storsjö martin at martin.st
Fri Nov 29 23:01:02 CET 2013


On Fri, 29 Nov 2013, Diego Biurrun wrote:

> ---
>
> This eliminates the "-w" option to enable warnings.  I'll gladly enable
> it through some setting in the Perl code itself if somebody tells me how.
>
> doc/texi2pod.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/texi2pod.pl b/doc/texi2pod.pl
> index 96d967b..8c4673a 100755
> --- a/doc/texi2pod.pl
> +++ b/doc/texi2pod.pl
> @@ -1,4 +1,4 @@
> -#! /usr/bin/perl -w
> +#!/usr/bin/env perl
>
> #   Copyright (C) 1999, 2000, 2001 Free Software Foundation, Inc.
>
> -- 
> 1.8.3.2

In general yes, and perhaps with "use warnings;" afterwards on a separate 
line as well.

However, this wouldn't actually fix the texi2pod issues on Derek's fate 
instances (I've asked him to test a very similar patch earlier), since his 
msys setup happens to contain perl in a nonstandard path, and it's a 
non-msys perl version (which doesn't handle the msys unix style paths). So 
for his particular case I guess either he'll have to sort out where the 
path conversions go wrong in that case, or just add --disable-doc to his 
setups.

But in general this patch in itself (with "use warnings;") sounds like a 
good idea.

// Martin


More information about the libav-devel mailing list