[libav-devel] [PATCH] configure: add strip flags checks

Diego Biurrun diego at biurrun.de
Thu Nov 28 02:52:12 CET 2013


On Mon, Nov 25, 2013 at 10:46:14AM +0100, Vittorio Giovara wrote:
> This will check if -wN '..@*' is available and fall back on -x if not;
> when none are available, do not run strip at all to prevent removing
> functions that might be actually needed.
> ---
> Now with correct escaping and proper TMPO check.
> This is being double-checked on oracle right now.
> Vittorio
> 
>  configure   |   24 ++++++++++++++++++++++++
>  library.mak |    2 +-
>  2 files changed, 25 insertions(+), 1 deletion(-)

LGTM in general, small issue ..

> --- a/configure
> +++ b/configure
> @@ -3954,6 +3972,11 @@ check_ldflags -Wl,--warn-common
>  
> +# add some strip flags
> +# -wN '..@*' is more selective than -x but not available everywhere
> +# however when both are unavailable do not strip at all

Add proper capitalization and periods please.  Especially multiline comments
are far less readable w/o.  That said, the comment is pretty redundant IMO.

Diego


More information about the libav-devel mailing list