[libav-devel] [PATCH] fate: add framerate filter tests

Anton Khirnov anton at khirnov.net
Wed Nov 20 13:09:40 CET 2013


On Wed, 20 Nov 2013 12:09:57 +0100, Vittorio Giovara <vittorio.giovara at gmail.com> wrote:
> ---
> Set the right order and name, added one more test.
> Vittorio
> 
>  tests/fate/filter-video.mak        |    6 ++++++
>  tests/ref/fate/filter-fps-double   |   26 ++++++++++++++++++++++++++
>  tests/ref/fate/filter-fps-esoteric |   26 ++++++++++++++++++++++++++
>  3 files changed, 58 insertions(+)
>  create mode 100644 tests/ref/fate/filter-fps-double
>  create mode 100644 tests/ref/fate/filter-fps-esoteric
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 573121d..b8f9111 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -24,6 +24,12 @@ fate-filter-fade: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf fade=in:0:25,fade=out
>  FATE_FILTER_VSYNTH-$(call ALLYES, INTERLACE_FILTER FIELDORDER_FILTER) += fate-filter-fieldorder
>  fate-filter-fieldorder: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf interlace=tff,fieldorder=bff -sws_flags +accurate_rnd+bitexact
>  
> +FATE_FILTER_VSYNTH-$(CONFIG_FPS_FILTER) += fate-filter-fps-double
> +fate-filter-fps-double: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf fps=fps=50:start_time=1 -frames 25
> +
> +FATE_FILTER_VSYNTH-$(CONFIG_FPS_FILTER) += fate-filter-fps-esoteric
> +fate-filter-fps-esoteric: CMD = framecrc -r 15 -c:v pgmyuv -i $(SRC) -vf fps=fps=29.97 -frames 25
> +
>  FATE_FILTER_VSYNTH-$(CONFIG_GRADFUN_FILTER) += fate-filter-gradfun
>  fate-filter-gradfun: CMD = framecrc -c:v pgmyuv -i $(SRC) -vf gradfun
>  

I'd rather have the names in fate-fps-<source framerate>-<destination framerate>
format. It carries more information, and is consistent with already existing
tests using a similar pattern.

> diff --git a/tests/ref/fate/filter-fps-double b/tests/ref/fate/filter-fps-double
> new file mode 100644
> index 0000000..59a4fe3
> --- /dev/null
> +++ b/tests/ref/fate/filter-fps-double
> @@ -0,0 +1,26 @@
> +#tb 0: 1/50
> +0,         50,         50,        1,   152064, 0x05b789ef
> +0,         51,         51,        1,   152064, 0x05b789ef
> +0,         52,         52,        1,   152064, 0x43d796b5
> +0,         53,         53,        1,   152064, 0x43d796b5
> +0,         54,         54,        1,   152064, 0xd780d887
> +0,         55,         55,        1,   152064, 0xd780d887
> +0,         56,         56,        1,   152064, 0x76d2a455
> +0,         57,         57,        1,   152064, 0x76d2a455
> +0,         58,         58,        1,   152064, 0x6dc3650e
> +0,         59,         59,        1,   152064, 0x6dc3650e
> +0,         60,         60,        1,   152064, 0x0f9d6aca
> +0,         61,         61,        1,   152064, 0x0f9d6aca
> +0,         62,         62,        1,   152064, 0xe295c51e
> +0,         63,         63,        1,   152064, 0xe295c51e
> +0,         64,         64,        1,   152064, 0xd766fc8d
> +0,         65,         65,        1,   152064, 0xd766fc8d
> +0,         66,         66,        1,   152064, 0xe22f7a30
> +0,         67,         67,        1,   152064, 0xe22f7a30
> +0,         68,         68,        1,   152064, 0x7fea4378
> +0,         69,         69,        1,   152064, 0x7fea4378
> +0,         70,         70,        1,   152064, 0xfa8d94fb
> +0,         71,         71,        1,   152064, 0xfa8d94fb
> +0,         72,         72,        1,   152064, 0x4c9737ab
> +0,         73,         73,        1,   152064, 0x4c9737ab
> +0,         74,         74,        1,   152064, 0xa50d01f8
> diff --git a/tests/ref/fate/filter-fps-esoteric b/tests/ref/fate/filter-fps-esoteric
> new file mode 100644
> index 0000000..f25d674
> --- /dev/null
> +++ b/tests/ref/fate/filter-fps-esoteric
> @@ -0,0 +1,26 @@
> +#tb 0: 100/2997
> +0,          0,          0,        1,   152064, 0x05b789ef
> +0,          1,          1,        1,   152064, 0x05b789ef
> +0,          2,          2,        1,   152064, 0x4bb46551
> +0,          3,          3,        1,   152064, 0x4bb46551
> +0,          4,          4,        1,   152064, 0x9dddf64a
> +0,          5,          5,        1,   152064, 0x9dddf64a
> +0,          6,          6,        1,   152064, 0x2a8380b0
> +0,          7,          7,        1,   152064, 0x2a8380b0
> +0,          8,          8,        1,   152064, 0x4de3b652
> +0,          9,          9,        1,   152064, 0x4de3b652
> +0,         10,         10,        1,   152064, 0xedb5a8e6
> +0,         11,         11,        1,   152064, 0xedb5a8e6
> +0,         12,         12,        1,   152064, 0xe20f7c23
> +0,         13,         13,        1,   152064, 0xe20f7c23
> +0,         14,         14,        1,   152064, 0x5ab58bac
> +0,         15,         15,        1,   152064, 0x5ab58bac
> +0,         16,         16,        1,   152064, 0x1f1b8026
> +0,         17,         17,        1,   152064, 0x1f1b8026
> +0,         18,         18,        1,   152064, 0x91373915
> +0,         19,         19,        1,   152064, 0x91373915
> +0,         20,         20,        1,   152064, 0x02344760
> +0,         21,         21,        1,   152064, 0x02344760
> +0,         22,         22,        1,   152064, 0x30f5fcd5
> +0,         23,         23,        1,   152064, 0x30f5fcd5
> +0,         24,         24,        1,   152064, 0xc711ad61

Sorry for being annoying, but this test does not actually test this conversion
very well, as it's indistinguishable from framerate doubling on this few frames
(not suggesting you add a test with a 1000 frames, but either test different
framerates, or think of some smarter way to check that the conversion is right)

-- 
Anton Khirnov


More information about the libav-devel mailing list