[libav-devel] [PATCH 1/4] metasound: add (some) missing modes

Diego Biurrun diego at biurrun.de
Fri Nov 8 16:54:24 CET 2013


On Fri, Nov 08, 2013 at 03:53:46PM +0100, Kostya Shishkov wrote:
> On 8 November 2013 15:28, Diego Biurrun <diego at biurrun.de> wrote:
> > On Fri, Nov 08, 2013 at 10:16:39AM +0100, Kostya Shishkov wrote:
> >> 8kHz @ 6kbps per channel modes are special and are not supported yet,
> >> 22kHz @ 20kbps per channel modes are less special and will be
> >> supported with the following patch
> >
> > You missed hooking up the added tables in metasound_data.h.  Doesn't this
> > create a large number of warnings about missing prototypes or some such?
> 
> Huh?
> As I remember it the only exported tables are ff_metasound_mode* and there
> are prototypes for all of them in metasound_data.h (including nonexisting ones),
> the rest of tables are referenced by them and are static.

Heh, I missed that the extern declarations for those functions are already
present in metasound_data.h although the tables themselves are not yet in
metasound_data.c.

Diego


More information about the libav-devel mailing list