[libav-devel] [PATCH 1/6] lavc: use buf[0] instead of data[0] in checks whether a frame is allocated

Hendrik Leppkes h.leppkes at gmail.com
Mon Nov 4 13:12:36 CET 2013


On Mon, Nov 4, 2013 at 1:05 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
> On Sun,  3 Nov 2013 23:27:45 +0100, Anton Khirnov <anton at khirnov.net>
> wrote:
>> data[0] may be NULL for valid frames with hwaccel pixel formats.
>
> This looks OK (and VLC already supplies a dummy buf[0] for hwaccel
> surfaces) but I would not expect downstreams to adapt anytime soon, for the
> sake of backward compatibility.

If downstream uses get_buffer2, they absolutely need to provide a
buf[0], and if downstream uses get_buffer, the compat layer should
provide a buf[0], IIRC.

Or am I missing something?

- Hendrik


More information about the libav-devel mailing list