[libav-devel] [PATCH] hpeldsp: Use the PAVGB macro
diego at biurrun.de
Sun Nov 3 21:18:42 CET 2013
On Sun, Nov 03, 2013 at 09:49:54PM +0200, Martin Storsjö wrote:
> On Sun, 3 Nov 2013, Luca Barbato wrote:
> >From: Mikulas Patocka <mikulas at artax.karlin.mff.cuni.cz>
> >There are instructions pavgb and pavgusb. Both instructions do the same
> >operation but they have different enconding. Pavgb exists in SSE (or
> >MMXEXT) instruction set and pavgusb exists in 3D-NOW instruction set.
> >livavcodec uses the macro PAVGB to select the proper instruction.
> >However, the function avg_pixels8_xy2 uses pavgb directly.
> >The bug seems to be introduced by commit:
> >Signed-off-by: Mikulas Patocka <mikulas at artax.karlin.mff.cuni.cz
> Missing trailing '>'?
> >Signed-off-by: Luca Barbato <lu_zero at gentoo.org>
> >libavcodec/x86/hpeldsp.asm | 26 +++++++++++++-------------
> >1 file changed, 13 insertions(+), 13 deletions(-)
> The patch itself looks good I guess although I don't know this area
> too well.
It does LGTM as well.
More information about the libav-devel