[libav-devel] [PATCH] imc: some cosmetics

Diego Biurrun diego at biurrun.de
Thu May 24 18:31:55 CEST 2012


imc: K&R formatting cosmetics

On Wed, May 23, 2012 at 06:59:53PM +0200, Kostya Shishkov wrote:
> On Tue, May 22, 2012 at 08:37:27PM +0200, Diego Biurrun wrote:
> > On Tue, May 22, 2012 at 07:46:41PM +0200, Kostya Shishkov wrote:
> > > @@ -582,44 +595,47 @@ static void imc_imdct256(IMCContext *q) {
> > >      q->fft.fft_calc   (&q->fft, q->samples);
> > 
> > This spacing looks weird.
> 
> not at all:
>     q->fft.fft_permute(&q->fft, q->samples);
>     q->fft.fft_calc   (&q->fft, q->samples);
> 
> [...]

weird

> -static void imc_calculate_coeffs(IMCContext* q, float* flcoeffs1, float* flcoeffs2, int* bandWidthT,
> -                                float* flcoeffs3, float* flcoeffs5)
> +static void imc_calculate_coeffs(IMCContext *q, float *flcoeffs1,
> +                                 float *flcoeffs2, int* bandWidthT,
> +                                 float *flcoeffs3, float *flcoeffs5)

int *

> @@ -245,41 +244,42 @@ static void imc_read_level_coeffs(IMCContext* q, int stream_format_code, int* le
> -static void imc_decode_level_coefficients(IMCContext* q, int* levlCoeffBuf, float* flcoeffs1,
> -                                         float* flcoeffs2)
> +static void imc_decode_level_coefficients(IMCContext *q, int* levlCoeffBuf,
> +                                          float *flcoeffs1, float *flcoeffs2)

same

> @@ -290,17 +290,20 @@ static void imc_decode_level_coefficients(IMCContext* q, int* levlCoeffBuf, floa
>  
> -static void imc_decode_level_coefficients2(IMCContext* q, int* levlCoeffBuf, float* old_floor, float* flcoeffs1,
> -                                          float* flcoeffs2) {
> +static void imc_decode_level_coefficients2(IMCContext *q, int* levlCoeffBuf,
> +                                           float* old_floor, float *flcoeffs1,
> +                                           float *flcoeffs2)

more

> @@ -629,22 +645,24 @@ static int inverse_quant_coeff (IMCContext* q, int stream_format_code) {
>  
> -//av_log(NULL,0,"Band %i coeff %i cw_len %i\n",i,j,cw_len);
> +//                    av_log(NULL, 0, "Band %i coeff %i cw_len %i\n", i, j, cw_len);

Indent the //.

Feel free to push eiththese issues addressed.

Diego


More information about the libav-devel mailing list