[libav-devel] [PATCH] avprobe: don't print format entry name when only one was requested

Måns Rullgård mans at mansr.com
Mon May 14 13:46:20 CEST 2012


Janne Grunau <janne-libav at jannau.net> writes:

> On 2012-05-07 23:58:32 +0200, Diego Biurrun wrote:
>> On Mon, May 07, 2012 at 10:02:39PM +0200, Anton Khirnov wrote:
>> > This is easier to parse with automated tools.
>> > ---
>> >  avprobe.c |    6 +++++-
>> >  1 file changed, 5 insertions(+), 1 deletion(-)
>> 
>> While generally desirable, this requires matching changes in FATE.
>> 
>> > --- a/avprobe.c
>> > +++ b/avprobe.c
>> > @@ -34,6 +34,7 @@ const int program_birth_year = 2007;
>> >  
>> >  static int do_show_format  = 0;
>> >  static AVDictionary *fmt_entries_to_show = NULL;
>> > +static int        nb_fmt_entries_to_show;
>> >  static int do_show_packets = 0;
>> >  static int do_show_streams = 0;
>> 
>> weird formatting
>
> I agree
>
>  static AVDictionary *fmt_entries_to_show = NULL;
> +static    int     nb_fmt_entries_to_show       ;
>
> would be a better vertical alignment ;)

There was a computer science professor at my university who insisted on
aligning all semicolons and curly braces way over in the right-hand
margin.  It made his C/java look almost like python and was impossible
for anyone else to read.

-- 
Måns Rullgård
mans at mansr.com


More information about the libav-devel mailing list