[libav-devel] [PATCH] sctp: Initial tcp-alike sctp support with streams

Måns Rullgård mans at mansr.com
Wed May 9 02:39:47 CEST 2012


Luca Barbato <lu_zero at gentoo.org> writes:

> On 08/05/12 17:26, Sean McGovern wrote:
>> On Tue, May 8, 2012 at 6:43 PM, Luca Barbato <lu_zero at gentoo.org> wrote:
>> 
>>> Signed-off-by: Jordi Ortiz <nenjordi at gmail.com>
>>> Signed-off-by: Luca Barbato <lu_zero at gentoo.org>
>>> ---
>>>  configure                |    3 +
>>>  libavformat/Makefile     |    1 +
>>>  libavformat/allformats.c |    1 +
>>>  libavformat/sctp.c       |  328
>>> ++++++++++++++++++++++++++++++++++++++++++++++
>>>  4 files changed, 333 insertions(+), 0 deletions(-)
>>>  create mode 100644 libavformat/sctp.c
>>>
>>>
>> This broke the Solaris build.
>> 
>> From the manpage for sctp_send:
>> 
>> NAME
>>      sctp_send - send message from an SCTP socket
>> 
>> SYNOPSIS
>>      cc [ flag... ] file... -lsocket -lnsl -lsctp [ library... ]
>>      #include <sys/types.h>
>>      #include <sys/socket.h>
>>      #include <netinet/sctp.h>
>> 
>> <..snip..>
>> 
>> So it looks like we need to link against libsctp (only on Solaris), and
>> make sure to #include <sys/types.h> and <sys/socket.h> before
>> <netinet/sctp.h> (currently we don't).
>
> We do not need libsctp, I guess reordering the includes should fix the
> problem, could you please test ^^?

That would mean moving the "network.h" include before whatever might
need sys/socket.h.  We don't include sys/socket.h directly since some
systems don't have it.

-- 
Måns Rullgård
mans at mansr.com


More information about the libav-devel mailing list