[libav-devel] [libav-commits] fate: Add avprobe as a make dependency
mans at mansr.com
Mon May 7 22:02:38 CEST 2012
Alex Converse <alex.converse at gmail.com> writes:
> On Mon, May 7, 2012 at 12:30 PM, Måns Rullgård <mans at mansr.com> wrote:
>> "Alex Converse " <git at libav.org> writes:
>>> Module: libav
>>> Branch: master
>>> Commit: 6345209a7d1ac2013704c42e3610a91f889f39ff
>>> Author: Alex Converse <alex.converse at gmail.com>
>>> Committer: Alex Converse <alex.converse at gmail.com>
>>> Date: Mon May 7 11:00:54 2012 -0700
>>> fate: Add avprobe as a make dependency
>>> tests/Makefile | 2 +-
>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>> diff --git a/tests/Makefile b/tests/Makefile
>>> index 56a8bb7..c440f04 100644
>>> --- a/tests/Makefile
>>> +++ b/tests/Makefile
>>> @@ -119,7 +119,7 @@ FATE_UTILS = base64 tiny_psnr
>>> fate: $(FATE)
>>> -$(FATE): avconv$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
>>> +$(FATE): avconv$(EXESUF) avprobe$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
>>> @echo "TEST $(@:fate-%=%)"
>>> $(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)" "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)' '$(THREADS)' '$(THREAD_TYPE)' '$(CPUFLAGS)' '$(CMP_SHIFT)' '$(CMP_TARGET)' '$(SIZE_TOLERANCE)'
>> Can we *PLEASE* allow a little more time before committing things? I
>> was out for an hour or so, and had no chance to NAK this until now.
> What terrible fate have we suffered from this being committed? The
> build was broken;
Not badly enough to rush things through without review.
The real breakage was caused by a different commit, which was also
rushed in without testing.
> I fixed it.
No, you patched it up to hide the fault. That is not the same thing.
> Feel free to refactor the changed build dependencies however you see
I don't have time to fix every fucking bad choice people make after the
mans at mansr.com
More information about the libav-devel