[libav-devel] [PATCH] mp3/ac3 probe: search for PES headers to prevent probing MPEG-PS as MP3.

Ronald S. Bultje rsbultje at gmail.com
Thu May 3 01:09:29 CEST 2012


Hi guys,

On Wed, May 2, 2012 at 4:06 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> From: "Ronald S. Bultje" <rsbultje at gmail.com>
>
> ---
>  libavformat/ac3dec.c |   29 ++++++++++++++++++++++++-----
>  libavformat/mp3dec.c |   29 ++++++++++++++++++++++++-----
>  2 files changed, 48 insertions(+), 10 deletions(-)

Please consider this a RFC, I'm interested in ideas here. What happens
for a significant amount of content is that it's detected as mp3 and
mpegps at equal score, and then this code:
http://git.libav.org/?p=libav.git;a=blob;f=libavformat/utils.c;h=b167e96854f57346c4eba40de598259e7aec0dd9;hb=HEAD#l339
will cause it to not be detected as anything at all. The above is a
symptom, the high score for mp3 is a bug. My idea is to detect mpegps
in mp3 and bias negatively if found. Anyone have better ideas? This
works for problem files I have found.

Ronald


More information about the libav-devel mailing list