[libav-devel] [GCI] Snow.c - cosmetics and reindent

Diego Biurrun diego at biurrun.de
Sun Nov 27 22:45:38 CET 2011


On Sun, Nov 27, 2011 at 10:07:55PM +0200, Asen Lekov wrote:
> 
> --- a/libavcodec/snow.c
> +++ b/libavcodec/snow.c
> @@ -35,46 +35,51 @@
>  
>      s->b_width = w;
> -    s->b_height= h;
> +    s->b_height = h;

Here (and in similar places) the '=' should end up vertically aligned,
i.e.:

  s->b_width  = w;
  s->b_height = h;

> +static void mc_block(Plane *p, uint8_t *dst, const uint8_t *src, int stride, 
> +                     int b_w, int b_h, int dx, int dy) 
> +{                   
> +    static const uint8_t weight[64]= {
> +        8,7,6,5,4,3,2,1,
> +        7,7,0,0,0,0,0,1,
> +        6,0,6,0,0,0,2,0,
> +        5,0,0,5,0,3,0,0,
> +        4,0,0,0,4,0,0,0,
> +        3,0,0,5,0,3,0,0,
> +        2,0,6,0,0,0,2,0,
> +        1,7,0,0,0,0,0,1,

space before '=' and after ',', same below

> +                if (!p || p->fast_mc) {
> +                    am = 20 * (a2+a3) - 5 * (a1+a4) + (a0+a5);

spaces around '+', more below

> +                } else {
> +                    am = p->hcoeff[0] * (a2+a3) + p->hcoeff[1] * (a1+a4) + 
> +                        p->hcoeff[2] * (a0+a5) + p->hcoeff[3] * (a_1+a6);

Indent the second line by one more space to make this more readable.

> -
> -                if(am&(~255)) am= ~(am>>31);
> -                tmp2[x]= am;
> +                if (am&(~255)) am = ~(am>>31);
> +                    tmp2[x] = am;

spaces around '&' and '>>'

I skipped the rest for now, you should get the idea.

Diego


More information about the libav-devel mailing list