[libav-devel] [PATCH 5/5] s3tc: fix shift overflow by using unsigned constant

Kostya Shishkov kostya.shishkov at gmail.com
Sat Nov 26 18:04:55 CET 2011


On Sat, Nov 26, 2011 at 04:52:11PM +0000, Mans Rullgard wrote:
> Signed-off-by: Mans Rullgard <mans at mansr.com>
> ---
>  libavcodec/s3tc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libavcodec/s3tc.c b/libavcodec/s3tc.c
> index e8ca688..d0c4eb8 100644
> --- a/libavcodec/s3tc.c
> +++ b/libavcodec/s3tc.c
> @@ -28,7 +28,7 @@
>  static inline void dxt1_decode_pixels(const uint8_t *s, uint32_t *d,
>                                        unsigned int qstride, unsigned int flag,
>                                        uint64_t alpha) {
> -    unsigned int x, y, c0, c1, a = (!flag * 255) << 24;
> +    unsigned int x, y, c0, c1, a = (!flag * 255u) << 24;
>      unsigned int rb0, rb1, rb2, rb3, g0, g1, g2, g3;
>      uint32_t colors[4], pixels;
>  

LGTM


More information about the libav-devel mailing list