[libav-devel] [PATCH] aacdec: add more fate tests covering SBR and PS

Måns Rullgård mans at mansr.com
Wed Nov 23 01:43:36 CET 2011


Janne Grunau <janne-libav at jannau.net> writes:

> fate-suite already updated, I'll wait at least 24 hours before committing
>
> Janne
> ---8<---
> Add all seven test bitstreams of Coding Technologies "aacPlus Decoder
> Check Package". The streams cover different ways to signal SBR and PS
> in different formats.
> ---
>  tests/fate/aac.mak |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
> index 8c80557..e5ffcf5 100644
> --- a/tests/fate/aac.mak
> +++ b/tests/fate/aac.mak
> @@ -38,6 +38,19 @@ FATE_AAC += fate-aac-ap05_48
>  fate-aac-ap05_48: CMD = pcm -i $(SAMPLES)/aac/ap05_48.mp4
>  fate-aac-ap05_48: REF = $(SAMPLES)/aac/ap05_48.s16
>  
> +fate-aac-ct%: CMD = pcm -i $(SAMPLES)/aac/CT_DecoderCheck/$(subst fate-aac-ct-,,$@)

$(@:fate-aac-ct-%=%) is a little simpler than the subst call.

> +fate-aac-ct%: REF = $(SAMPLES)/aac/CT_DecoderCheck/aacPlusv2.wav
> +
> +FATE_AAC_CT = sbr_bc-ps_i.3gp  \
> +              sbr_bic-ps_i.3gp \
> +              sbr_i-ps_i.aac   \
> +              sbr_bc-ps_bc.mp4 \
> +              sbr_bc-ps_i.mp4  \
> +              sbr_i-ps_bic.mp4 \
> +              sbr_i-ps_i.mp4
> +
> +FATE_AAC += $(FATE_AAC_CT:%=fate-aac-ct-%)
> +
>  FATE_TESTS += $(FATE_AAC)
>  fate-aac: $(FATE_AAC)
>  $(FATE_AAC): CMP = oneoff
> -- 

Looks OK otherwise.

-- 
Måns Rullgård
mans at mansr.com


More information about the libav-devel mailing list